foxygit / doom Log in
commit 5e2df0a52e67fb9c696aec68ec5ee0b466eac6a9
Author:     Turo Lamminen <turotl@gmail.com>
AuthorDate: Sat Jan 6 15:02:00 2018 +0200
Commit:     Turo Lamminen <turotl@gmail.com>
CommitDate: Sat Jan 27 16:46:04 2018 +0200

    textscreen: Don't ignore return value of system() call
---
 textscreen/txt_window.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/textscreen/txt_window.c b/textscreen/txt_window.c
index f2fda774..54f84fdb 100644
--- a/textscreen/txt_window.c
+++ b/textscreen/txt_window.c
@@ -526,6 +526,7 @@ void TXT_OpenURL(char *url)
 {
     char *cmd;
     size_t cmd_len;
+    int retval;

     cmd_len = strlen(url) + 30;
     cmd = malloc(cmd_len);
@@ -546,8 +547,13 @@ void TXT_OpenURL(char *url)
     TXT_snprintf(cmd, cmd_len, "xdg-open \"%s\"", url);
 #endif

-    system(cmd);
+    retval = system(cmd);
     free(cmd);
+    if (retval != 0)
+    {
+        fprintf(stderr, "TXT_OpenURL: error executing '%s'; return code %d\n",
+            cmd, retval);
+    }
 }

 #endif /* #ifndef _WIN32 */