foxygit / doom Log in
commit b44b84beb3d7c3cf7e56bf1796d49102c5f9e562
Author:     Mike Swanson <mikeonthecomputer@gmail.com>
AuthorDate: Sat Jun 6 10:52:33 2015 -0700
Commit:     Mike Swanson <mikeonthecomputer@gmail.com>
CommitDate: Sat Jun 6 10:52:33 2015 -0700

    textscreen: Pass url directly to ShellExecute, snprintf unneeded
---
 textscreen/txt_window.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/textscreen/txt_window.c b/textscreen/txt_window.c
index 44cdf9d1..41b8c8ef 100644
--- a/textscreen/txt_window.c
+++ b/textscreen/txt_window.c
@@ -521,11 +521,9 @@ void TXT_OpenURL(char *url)
     cmd_len = strlen(url) + 30;
     cmd = malloc(cmd_len);

-#if defined(_WIN32)
-    TXT_snprintf(cmd, cmd_len, "%s", url);
-#elif defined(__MACOSX__)
+#if defined(__MACOSX__)
     TXT_snprintf(cmd, cmd_len, "open \"%s\"", url);
-#else
+#elif !defined(_WIN32)
     // The Unix situation sucks as usual, but the closest thing to a
     // standard that exists is the xdg-utils package.
     if (system("xdg-open --version 2>/dev/null") != 0)
@@ -539,7 +537,7 @@ void TXT_OpenURL(char *url)
 #endif

 #if defined(_WIN32)
-    ShellExecute(NULL, "open", cmd, NULL, NULL, SW_SHOWNORMAL);
+    ShellExecute(NULL, "open", url, NULL, NULL, SW_SHOWNORMAL);
 #else
     system(cmd);
 #endif