commit 6478a56726884d731039d1a38ff376ee955e1783
Author: Fabian Greffrath <fabian@greffrath.com>
AuthorDate: Mon Jan 28 09:25:31 2019 +0100
Commit: Fabian Greffrath <fabian@greffrath.com>
CommitDate: Mon Jan 28 09:25:31 2019 +0100
net: explicitly declare a bit-shifted 1 literal as unsigned
This fixes a future "Shifting signed 32-bit value by 31 bits is
undefined behaviour" cppcheck error.
---
src/net_packet.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/net_packet.c b/src/net_packet.c
index aa187f8d..23bfda67 100644
--- a/src/net_packet.c
+++ b/src/net_packet.c
@@ -158,10 +158,10 @@ boolean NET_ReadSInt32(net_packet_t *packet, signed int *data)
{
if (NET_ReadInt32(packet, (unsigned int *) data))
{
- if (*data & (1 << 31))
+ if (*data & (1U << 31))
{
- *data &= ~(1 << 31);
- *data -= (1 << 31);
+ *data &= ~(1U << 31);
+ *data -= (1U << 31);
}
return true;
}